flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fabian Hueske (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1085) Unnecessary failing of GroupReduceCombineDriver
Date Tue, 02 Sep 2014 13:03:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118167#comment-14118167

Fabian Hueske commented on FLINK-1085:

No, just found it while browsing the code and since forwarding is OK for combine it's not
necessary to fail the job.
The job might fail later in Reduce due to the same problem, but that shouldn't be a reason
to fail it here IMO.

> Unnecessary failing of GroupReduceCombineDriver
> -----------------------------------------------
>                 Key: FLINK-1085
>                 URL: https://issues.apache.org/jira/browse/FLINK-1085
>             Project: Flink
>          Issue Type: Bug
>          Components: Local Runtime
>    Affects Versions: 0.7-incubating, 0.6.1-incubating
>            Reporter: Fabian Hueske
>              Labels: starter
> With a recent update (commit cbbcf7820885a8a9734ffeba637b0182a6637939) the GroupReduceCombineDriver
was changed to not use an asynchronous partial sorter. Instead, the driver fills a sort buffer
with records, sorts it, combines them, clears the buffer, and continues to fill it again.
> The GroupReduceCombineDriver fails if a record cannot be serialized into an empty sort
buffer, i.e., if the record is too large for the buffer.
> Alternatively, we should emit a WARN message for the first record that is too large and
just forward all records which do not fit into the empty sort buffer (maybe continue to count
how many records were simply forwarded and give a second WARN message with this statistic).

This message was sent by Atlassian JIRA

View raw message