flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsaputra <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Cleanup LOG.debug to make sure no ex...
Date Thu, 25 Sep 2014 23:06:28 GMT
GitHub user hsaputra opened a pull request:

    https://github.com/apache/incubator-flink/pull/127

    Cleanup LOG.debug to make sure no extra toString and unnecessary String concatenation

    The PR contains:
    -) Remove unnecessary type check and cast for FileInputSplit in FileInputFormat.java.
    -) Update LOG.debug to user SLF4J parameterized logging or protected by LOG.isDebugEnabled
to save toString and String concat. I use SLF4J parameterized logging if it is just logging
String or object via its toString and add LOG.isDebugEnabled if it requires calling method
to get the message/object.
    
    Pass tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsaputra/incubator-flink cleanup_code_1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 5a1aa7284fbe20a5c36a715ac3555582a7cfa849
Author: Henry Saputra <henry.saputra@gmail.com>
Date:   2014-09-24T17:40:19Z

    Remove unnecessary type check and cast for FileInputSPlit.

commit 98f4a4262288ef255ee96cccfc102bc4b6cffa9b
Author: Henry Saputra <henry.saputra@gmail.com>
Date:   2014-09-25T22:43:34Z

    Update LOG.debug to user SLF4J parameterized logging or protected by LOG.isDebugEnabled
to save toString and String concat.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message