flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Flink 1134
Date Fri, 03 Oct 2014 07:40:23 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/138#discussion_r18384247
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/RemoteCollectorImpl.java
---
    @@ -75,6 +87,8 @@
     
     			registry = LocateRegistry.createRegistry(port);
     			registry.bind(rmiId, collectorInstance);
    +			
    +			registries.add(registry);
     		} catch (RemoteException e) {
     			e.printStackTrace();
    --- End diff --
    
    I would recommend the re-throw such exceptions as RuntimeExceptions! If you are printing
the stack-trace, just the stack trace (without error message) will appear on some TaskManager's
log files. 
    if you throw a RuntimeE., the job execution will abort and the user will see the exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message