flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-1032] Rework support for POJO...
Date Sun, 05 Oct 2014 15:53:59 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/141#issuecomment-57940493
  
    Thank you for the thorough review. I'll address the issues.
    
    Regarding the serializer test, there is the `PojoSerializerTest extends SerializerTestBase<PojoSerializerTest.TestUserClass>`.
It is doing 12 tests (copy, instantiation, etc).
    I'll look into the Tuple Serializer tests and see what I can do for the PojoSerializer.
But there are definitively tests for the comparator missing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message