flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1032) Extend POJO Field Selectors to Support Accessing Nested Objects
Date Mon, 06 Oct 2014 09:03:34 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160118#comment-14160118
] 

ASF GitHub Bot commented on FLINK-1032:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/141#discussion_r18446562
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java
---
    @@ -139,7 +139,8 @@ public void setCombinable(boolean combinable) {
     			
     			return po;
     		}
    -		else if (grouper.getKeys() instanceof Keys.FieldPositionKeys) {
    +		else if (grouper.getKeys() instanceof Keys.ExpressionKeys) { //was field position key
    +			//TODO ask stephan
    --- End diff --
    
    Should get rid of this TODO.


> Extend POJO Field Selectors to Support Accessing Nested Objects
> ---------------------------------------------------------------
>
>                 Key: FLINK-1032
>                 URL: https://issues.apache.org/jira/browse/FLINK-1032
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Java API
>            Reporter: Aljoscha Krettek
>            Assignee: Robert Metzger
>
> Right now you can only use fields of the top-level object as key fields in groupings,
joins, and co-group. This should be extended to allow using nested fields. We have to be careful
with null fields, though.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message