flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From he-sk <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-1293] Add support for out-of-...
Date Mon, 01 Dec 2014 16:35:30 GMT
Github user he-sk commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/243#discussion_r21100077
  
    --- Diff: flink-examples/flink-java-examples/src/test/java/org/apache/flink/examples/java/aggregation/AggregationApi1Test.java
---
    @@ -0,0 +1,448 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.examples.java.aggregation;
    +
    +import static java.util.Arrays.asList;
    +import static org.apache.flink.api.java.aggregation.Aggregations.allKeys;
    +import static org.apache.flink.api.java.aggregation.Aggregations.average;
    +import static org.apache.flink.api.java.aggregation.Aggregations.count;
    +import static org.apache.flink.api.java.aggregation.Aggregations.key;
    +import static org.apache.flink.api.java.aggregation.Aggregations.max;
    +import static org.apache.flink.api.java.aggregation.Aggregations.min;
    +import static org.apache.flink.api.java.aggregation.Aggregations.sum;
    +import static org.junit.Assert.assertThat;
    +
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.Collections;
    +import java.util.Comparator;
    +import java.util.List;
    +
    +import org.apache.flink.api.java.DataSet;
    +import org.apache.flink.api.java.ExecutionEnvironment;
    +import org.apache.flink.api.java.aggregation.AggregationFunction;
    +import org.apache.flink.api.java.io.LocalCollectionOutputFormat;
    +import org.apache.flink.api.java.tuple.Tuple;
    +import org.apache.flink.api.java.tuple.Tuple1;
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import org.apache.flink.api.java.tuple.Tuple3;
    +import org.apache.flink.api.java.tuple.Tuple5;
    +import org.apache.flink.api.java.tuple.Tuple6;
    +import org.apache.flink.api.java.tuple.Tuple7;
    +import org.apache.flink.api.java.tuple.builder.Tuple1Builder;
    +import org.apache.flink.api.java.tuple.builder.Tuple2Builder;
    +import org.apache.flink.api.java.tuple.builder.Tuple3Builder;
    +import org.apache.flink.api.java.tuple.builder.Tuple6Builder;
    +import org.hamcrest.Description;
    +import org.hamcrest.Matcher;
    +import org.hamcrest.TypeSafeMatcher;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +public class AggregationApi1Test {
    --- End diff --
    
    AggregationTest is a better name because the alternative API is no longer in the branch.
    
    However, I'm not sure about the location of the test. It looks more like a unit test because
it checks various correct call patterns and error conditions. However, for many tests it constructs
a complete execution environment and consequently runs slow.
    
    In addition it cannot be in the flink-java package because the execution environment is
in flink-runtime which depends on flink-java and then you have a circular dependency.
    
    I think the best place would be flink-tests but I don't want to have it run as an integration
test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message