flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1112) Add GroupSorting with KeySelectors
Date Mon, 01 Dec 2014 16:31:14 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229987#comment-14229987
] 

ASF GitHub Bot commented on FLINK-1112:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/209#discussion_r21099693
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/translation/Tuple3WrappingCollector.java
---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.operators.translation;
    +
    +import org.apache.flink.api.java.tuple.Tuple3;
    +import org.apache.flink.util.Collector;
    +
    +/**
    + * Needed to wrap tuples to Tuple3<groupKey, sortKey, value> for combine method
of group reduce with key selector sorting
    + */
    +public class Tuple3WrappingCollector<IN, K1, K2> implements Collector<IN>,
java.io.Serializable {
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	private final Tuple3UnwrappingIterator<IN, K1, K2> tui;
    +	private final Tuple3<K1, K2, IN> outTuple;
    +
    +	private Collector<Tuple3<K1, K2, IN>> wrappedCollector;
    +
    +
    +	public Tuple3WrappingCollector(Tuple3UnwrappingIterator<IN, K1, K2> tui) {
    +		this.tui = tui;
    +		this.outTuple = new Tuple3<K1, K2, IN>();
    +	}
    +
    +	public void set(Collector<Tuple3<K1, K2, IN>> wrappedCollector) {
    +		this.wrappedCollector = wrappedCollector;
    +	}
    +
    +	@Override
    +	public void close() {
    +		this.wrappedCollector.close();
    +	}
    +
    +	@Override
    +	public void collect(IN record) {
    +		this.outTuple.f0 = this.tui.getLastKey();
    +		this.outTuple.f2 = record;
    --- End diff --
    
    the sort key must also be forwarded by the combiner collector.


> Add GroupSorting with KeySelectors
> ----------------------------------
>
>                 Key: FLINK-1112
>                 URL: https://issues.apache.org/jira/browse/FLINK-1112
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>            Reporter: Fabian Hueske
>            Assignee: Mingliang Qi
>
> Group sorting is currently only supported for field-index keys and not for KeySelectors.
> This feature was requested.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message