flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1112) Add GroupSorting with KeySelectors
Date Mon, 01 Dec 2014 16:34:15 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229995#comment-14229995
] 

ASF GitHub Bot commented on FLINK-1112:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/incubator-flink/pull/209#issuecomment-65091843
  
    Thanks for the pull request! 
    I added some comments in-line.
    
    Could you also add the following tests to the Java and Scala integration tests:
    - KeyExtractor returns a Tuple2 as key
    - GroupReduce function is combinable (including the checks that the elements are processed
by the combiner in the right order).
    
    Thank you very much!


> Add GroupSorting with KeySelectors
> ----------------------------------
>
>                 Key: FLINK-1112
>                 URL: https://issues.apache.org/jira/browse/FLINK-1112
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>            Reporter: Fabian Hueske
>            Assignee: Mingliang Qi
>
> Group sorting is currently only supported for field-index keys and not for KeySelectors.
> This feature was requested.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message