flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1293) Add support for out-of-place aggregations
Date Mon, 01 Dec 2014 16:46:14 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230018#comment-14230018
] 

ASF GitHub Bot commented on FLINK-1293:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/243#discussion_r21100873
  
    --- Diff: flink-examples/flink-java-examples/src/test/java/org/apache/flink/examples/java/aggregation/AggregationApi1Test.java
---
    @@ -0,0 +1,448 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.examples.java.aggregation;
    +
    +import static java.util.Arrays.asList;
    +import static org.apache.flink.api.java.aggregation.Aggregations.allKeys;
    +import static org.apache.flink.api.java.aggregation.Aggregations.average;
    +import static org.apache.flink.api.java.aggregation.Aggregations.count;
    +import static org.apache.flink.api.java.aggregation.Aggregations.key;
    +import static org.apache.flink.api.java.aggregation.Aggregations.max;
    +import static org.apache.flink.api.java.aggregation.Aggregations.min;
    +import static org.apache.flink.api.java.aggregation.Aggregations.sum;
    +import static org.junit.Assert.assertThat;
    +
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.Collections;
    +import java.util.Comparator;
    +import java.util.List;
    +
    +import org.apache.flink.api.java.DataSet;
    +import org.apache.flink.api.java.ExecutionEnvironment;
    +import org.apache.flink.api.java.aggregation.AggregationFunction;
    +import org.apache.flink.api.java.io.LocalCollectionOutputFormat;
    +import org.apache.flink.api.java.tuple.Tuple;
    +import org.apache.flink.api.java.tuple.Tuple1;
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import org.apache.flink.api.java.tuple.Tuple3;
    +import org.apache.flink.api.java.tuple.Tuple5;
    +import org.apache.flink.api.java.tuple.Tuple6;
    +import org.apache.flink.api.java.tuple.Tuple7;
    +import org.apache.flink.api.java.tuple.builder.Tuple1Builder;
    +import org.apache.flink.api.java.tuple.builder.Tuple2Builder;
    +import org.apache.flink.api.java.tuple.builder.Tuple3Builder;
    +import org.apache.flink.api.java.tuple.builder.Tuple6Builder;
    +import org.hamcrest.Description;
    +import org.hamcrest.Matcher;
    +import org.hamcrest.TypeSafeMatcher;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +public class AggregationApi1Test {
    --- End diff --
    
    Can you separate the pre-execution tests and the tests that check for result correctness
into two classes?
    The other operator have pre-flight tests as unit tests in flink-java and the tests that
execute programs as IntegrationTests in flink-test.


> Add support for out-of-place aggregations
> -----------------------------------------
>
>                 Key: FLINK-1293
>                 URL: https://issues.apache.org/jira/browse/FLINK-1293
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 0.7.0-incubating
>            Reporter: Viktor Rosenfeld
>            Assignee: Viktor Rosenfeld
>            Priority: Minor
>
> Currently, the output of an aggregation is of the same type as the input. This restriction
has to major drawbacks:
> 1. Every tuple field can only be used in one aggregation because the aggregations result
is stored in the field.
> 2. Aggregations having a return type that is different from the input type, e.g., count
or average, cannot be implemented.
> It would be nice to have the aggregation return any kind of tuple as a result, so the
restrictions above no longer apply.
> See also:
> - https://github.com/stratosphere/stratosphere/wiki/Design-of-Aggregate-Operator
> - http://apache-flink-incubator-mailing-list-archive.1008284.n3.nabble.com/Hi-Aggregation-support-td2311.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message