flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1320] Add an off-heap variant of the ma...
Date Thu, 08 Jan 2015 11:38:23 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/290#discussion_r22647093
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/bufferprovider/GlobalBufferPool.java
---
    @@ -63,8 +64,13 @@ public GlobalBufferPool(int numBuffers, int bufferSize) {
     
     		for (int i = 0; i < numBuffers; i++) {
     			try {
    -				byte[] buf = new byte[bufferSize];
    -				buffers.add(new MemorySegment(buf));
    +				// TODO if (config) {
    --- End diff --
    
    Thanks for pointing that out. They are currently used in the memory manager of the task
manager but not for the GlobalBufferPool. I probably want to fix that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message