flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1229) Synchronize WebClient arguments with command line arguments
Date Fri, 09 Jan 2015 16:29:34 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271484#comment-14271484
] 

ASF GitHub Bot commented on FLINK-1229:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/291#discussion_r22725429
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/web/JobSubmissionServlet.java
---
    @@ -146,10 +146,22 @@ protected void doGet(HttpServletRequest req, HttpServletResponse
resp) throws Se
     			}
     
     			String assemblerClass = null;
    -			if (params.size() >= 2 && params.get(0).equals("assembler")) {
    -				assemblerClass = params.get(1);
    -				params.remove(0);
    -				params.remove(0);
    +			int pos = 0;
    +			int parallelism = -1;
    +			while(pos < params.size()) {
    +				if (params.get(pos).equals("-c")) {
    +					assemblerClass = params.get(pos + 1);
    +					params.remove(pos);
    +					params.remove(pos);
    +				}
    +				else if (params.get(pos).equals("-p")) {
    +					parallelism = Integer.parseInt(params.get(pos + 1));
    +					params.remove(pos);
    +					params.remove(pos);
    +				}
    +				else {
    +					pos++;
    --- End diff --
    
    If you change this to `break`, it will only accept these flags before the user program
arguments (not mixed with them), which makes sense and reflects the way the command line handles
it.


> Synchronize WebClient arguments with command line arguments
> -----------------------------------------------------------
>
>                 Key: FLINK-1229
>                 URL: https://issues.apache.org/jira/browse/FLINK-1229
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>            Reporter: Timo Walther
>            Priority: Minor
>
> In the webclient, the -c option is not supported. The weblient takes the command in the
form {code}assembler org.apache.flink.WordCountJob{code}
> Should be consistent with the command line scripts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message