flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...
Date Mon, 02 Feb 2015 19:40:20 GMT
Github user rmetzger commented on a diff in the pull request:

    --- Diff: flink-addons/flink-language-binding/src/main/java/org/apache/flink/languagebinding/api/java/common/OperationInfo.java
    @@ -0,0 +1,48 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
agreements. See the NOTICE
    + * file distributed with this work for additional information regarding copyright ownership.
The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the "License"); you may not use this
file except in compliance with the
    + * License. You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License is distributed on
implied. See the License for the
    + * specific language governing permissions and limitations under the License.
    + */
    +package org.apache.flink.languagebinding.api.java.common;
    + * Container for all generic information related to operations. This class contains the
absolute minimum fields that are
    + * required for all operations. This class should be extended to contain any additional
fields required on a
    + * per-language basis.
    + */
    +public abstract class OperationInfo {
    +	public int parentID; //DataSet that an operation is applied on
    +	public int otherID; //secondary DataSet
    +	public int setID; //ID for new DataSet
    +	public int[] keys1; //grouping keys
    +	public int[] keys2; //grouping keys
    +	public int[] projectionKeys1; //projection keys
    +	public int[] projectionKeys2; //projection keys
    +	public Object types; //an object that is of the same type as the output type
    --- End diff --
    Why are you passing around the objects to the Python operators?
    Wouldn't it be easier to extract the types as early as possible and hand around the TypeInformation

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message