flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1166] Add qa-check.sh tool
Date Thu, 05 Feb 2015 17:24:50 GMT
Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/366#issuecomment-73087911
  
    I just ran the script on your pull request ;)
    
    > Flink QA-Check results:
    > :+1: The number of javadoc errors was      402 and is now      402
    > :-1: The change increases the number of compiler warnings from      104 to      314
    > :+1: The number of files in the lib/ folder was      142 before the change and is
now      142
    
    > Test finished.
    > Overall result: :-1:. Some tests failed. Please check messages above
    
    I guess if the user does not rebase to the latest master, then negative QA test results
are likely to occur. Also, warnings could be hidden when the number of warnings have increased
on the master. Wouldn't it be better to compare against the base of the user's changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message