flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1193) InvalidTypesException for Array[Array[Tuple2[Int, Double]]]
Date Tue, 03 Feb 2015 10:42:34 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303060#comment-14303060
] 

ASF GitHub Bot commented on FLINK-1193:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/348#discussion_r23995382
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArraySerializer.java
---
    @@ -72,7 +72,9 @@ public boolean isStateful() {
     		C[] copy = create(from.length);
     
     		for (int i = 0; i < copy.length; i++) {
    -			copy[i] = this.componentSerializer.copy(from[i], this.componentSerializer.createInstance());
    +			if (from[i] != null) {
    +				copy[i] = this.componentSerializer.copy(from[i], this.componentSerializer.createInstance());
    --- End diff --
    
    This should not use the method with re-usable instance.


> InvalidTypesException for Array[Array[Tuple2[Int, Double]]]
> -----------------------------------------------------------
>
>                 Key: FLINK-1193
>                 URL: https://issues.apache.org/jira/browse/FLINK-1193
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Till Rohrmann
>            Assignee: Timo Walther
>
> The TypeExtractor cannot handle nested arrays with non-trivial element types. For example,
the following code cannot be run
> {code}
> val input = env.fromCollection(List(1,2,3,4))
> val mapped = input.map{
>   id => {
>     val pair = (1,1.0)
>     val a = Array(pair)
>     val b = Array(a)
>     b
>   }
> }
> {code}
> The resulting type Array[Array[Tuple2[Int, Double]]] cannot be extracted. It would be
nice, if Flink supported these types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message