flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1508) Remove AkkaUtils.ask to encourage explicit future handling
Date Thu, 12 Feb 2015 18:02:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318642#comment-14318642
] 

ASF GitHub Bot commented on FLINK-1508:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/384#issuecomment-74119549
  
    I vote to merge this quickly and fix issues as they appear. 
    The change touches a lot of different parts of the code and is predestined to become unmergeable
quickly.


> Remove AkkaUtils.ask to encourage explicit future handling
> ----------------------------------------------------------
>
>                 Key: FLINK-1508
>                 URL: https://issues.apache.org/jira/browse/FLINK-1508
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Till Rohrmann
>
> {{AkkaUtils.ask}} asks another actor and awaits its response. Since this constitutes
a blocking call, it might be potentially harmful when used in an actor thread. In order to
encourage developers to program asynchronously I propose to remove this helper function. That
forces the developer to handle futures explicitly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message