flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Saputra (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FLINK-1542) Test case at BlobUtilsTest should not assume user could not create new item in root directory
Date Fri, 13 Feb 2015 22:00:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320815#comment-14320815
] 

Henry Saputra edited comment on FLINK-1542 at 2/13/15 9:59 PM:
---------------------------------------------------------------

GitHub user hsaputra opened a pull request:

    https://github.com/apache/flink/pull/396

    [FLINK-1542] Test case at BlobUtilsTest should not assume user could not create new item
in root directory

    Sometimes, user that run tests could have write access to root dir such as creating /cannot-create-this
    is possible, hence to exception thrown.
    
    Need to construct a Flink test directory under directory specified under "java.io.tmpdir"
and change the permission to not allow create new
    directory.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsaputra/flink FLINK-1542_fix_BlobUtilsTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #396
    
----
commit c56044ef5cd072a3684dfe7b723f359e0642f04e
Author: Henry Saputra <henry.saputra@gmail.com>
Date:   2015-02-13T21:44:29Z

    [FLINK-1542] Test case at BlobUtilsTest should not assume user could not create new item
in root directory
    
    Sometimes, user that run tests could have write access to root dir such as creating /cannot-create-this
    is possible, hence to exception thrown.
    
    Need to construct a Flink test directory under directory specified under "java.io.tmpdir"
and change the permission to not allow create new
    directory.

----



was (Author: githubbot):
GitHub user hsaputra opened a pull request:

    https://github.com/apache/flink/pull/396

    [FLINK-1542] Test case at BlobUtilsTest should not assume user could not create new item
in root directory

    [FLINK-1542] Test case at BlobUtilsTest should not assume user could not create new item
in root directory
    
    Sometimes, user that run tests could have write access to root dir such as creating /cannot-create-this
    is possible, hence to exception thrown.
    
    Need to construct a Flink test directory under directory specified under "java.io.tmpdir"
and change the permission to not allow create new
    directory.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsaputra/flink FLINK-1542_fix_BlobUtilsTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #396
    
----
commit c56044ef5cd072a3684dfe7b723f359e0642f04e
Author: Henry Saputra <henry.saputra@gmail.com>
Date:   2015-02-13T21:44:29Z

    [FLINK-1542] Test case at BlobUtilsTest should not assume user could not create new item
in root directory
    
    Sometimes, user that run tests could have write access to root dir such as creating /cannot-create-this
    is possible, hence to exception thrown.
    
    Need to construct a Flink test directory under directory specified under "java.io.tmpdir"
and change the permission to not allow create new
    directory.

----


> Test case at BlobUtilsTest should not assume user could not create new item in root directory
> ---------------------------------------------------------------------------------------------
>
>                 Key: FLINK-1542
>                 URL: https://issues.apache.org/jira/browse/FLINK-1542
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>
> The test at BlobUtilsTest #testExceptionOnCreateStorageDirectoryFailure assume that current
user cannot create new directory at root.
> In my MacOSX, my user has admin group so the test will always fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message