flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1792] TM Monitoring: CPU utilization, h...
Date Wed, 01 Apr 2015 08:14:52 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/553#discussion_r27551487
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
    @@ -129,6 +129,10 @@ class TaskManager(val connectionInfo: InstanceConnectionInfo,
         override def getValue: Double =
           ManagementFactory.getOperatingSystemMXBean().getSystemLoadAverage()
       })
    +  metricRegistry.register("cpuLoad", new Gauge[Double] {
    +    override def getValue: Double =
    +      ManagementFactory.getOperatingSystemMXBean().asInstanceOf[com.sun.management.OperatingSystemMXBean].getProcessCpuLoad()
    --- End diff --
    
    This cast may fail on some JVM implementations. See http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
    Can you surround the metric registration by a try catch block and log a warning in case
the cast fails?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message