flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1589] Add option to pass configuration ...
Date Wed, 01 Apr 2015 12:32:03 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/427#discussion_r27564491
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
    @@ -103,6 +110,9 @@ public void start() throws Exception {
     				
     				// create the embedded runtime
     				Configuration configuration = getConfiguration(this);
    +				if(this.configuration != null) {
    +					configuration.addAll(this.configuration);
    +				}
    --- End diff --
    
    Wouldn't it be better to move the null check to the constructor and create the default
`Configuration` there via a call to `getConfiguration`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message