flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1811] Allow passing custom buffer sizes...
Date Wed, 01 Apr 2015 13:24:48 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/558#discussion_r27568089
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/simple/PersistentKafkaSource.java
---
    @@ -211,6 +215,16 @@ public void run(Collector<OUT> collector) throws Exception
{
     		}
     	}
     
    +	public void setConnectTimeoutMs(int connectTimeoutMs) {
    +		Preconditions.checkArgument(connectTimeoutMs > 0, "The timeout must be positive");
    +		this.connectTimeoutMs = connectTimeoutMs;
    +	}
    +
    +	public void setBufferSize(int bufferSize) {
    +		Preconditions.checkArgument(connectTimeoutMs > 0, "The buffer size be positive");
    --- End diff --
    
    typo: missing "must"... I think we should add these checks in the constructor as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message