flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1716] Adds CoCoA algorithm
Date Thu, 02 Apr 2015 08:58:23 GMT
Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/545#issuecomment-88834217
  
    Hi @tillrohrmann! Thanks for the heads up :)
    The failing test is `DegreesWithExceptionITCase` and it seems that it fails because of
not throwing the excepted exception type. We had a discussion about this in #475 and if I
get it correctly, we can't be sure which exception will be reported to the client, because
of the job cancelling. Thus, we removed the check of the exception type and message and only
checked for failure.
    However, I see you added some exception checks in 36b762e. So, I'm not sure what we're
supposed to do with this test now, so that it doesn't fail o.O


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message