flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1792] TM Monitoring: CPU utilization, h...
Date Fri, 10 Apr 2015 13:07:49 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/553#discussion_r28142528
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
    @@ -129,6 +129,25 @@ class TaskManager(val connectionInfo: InstanceConnectionInfo,
         override def getValue: Double =
           ManagementFactory.getOperatingSystemMXBean().getSystemLoadAverage()
       })
    +  metricRegistry.register("cpuLoad", new Gauge[Double] {
    +    override def getValue: Double = {
    +      try{
    +        val osMXBean = ManagementFactory.getOperatingSystemMXBean().
    +          asInstanceOf[com.sun.management.OperatingSystemMXBean]
    +        return fetchCPULoad(osMXBean).asInstanceOf[Double]
    +      } catch {
    --- End diff --
    
    On JVMs not having the `OperatingSystemMXBean` we'll log a full stack trace on each heartbeat
(each time we collect metrics).
    
    I would only register the "cpuLoad" metric if we know that we can cast the OSMXBean to
`OperatingSystemMXBean` and when the `getProcessCpuLoad()` method is available.
    Otherwise, I would register a dummy method that is always returning -1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message