flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1753) Add more tests for Kafka Connectors
Date Mon, 13 Apr 2015 10:16:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492231#comment-14492231
] 

ASF GitHub Bot commented on FLINK-1753:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/589#discussion_r28227565
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/KafkaSink.java
---
    @@ -114,17 +132,24 @@ public KafkaSink(String zookeeperAddress, String topicId,
     	public void open(Configuration configuration) {
     
     		KafkaTopicUtils kafkaTopicUtils = new KafkaTopicUtils(zookeeperAddress);
    -		String brokerAddress = kafkaTopicUtils.getLeaderBrokerAddressForTopic(topicId);
    +		String listOfBrokers = kafkaTopicUtils.getBrokerList(topicId);
    +
    +		if (LOG.isInfoEnabled()) {
    +			LOG.info("Broker list: {}", listOfBrokers);
    +		}
     
    -		props = new Properties();
    +		if (props == null) {
    --- End diff --
    
    How about always setting our default properties (broker list, max retries etc.) and overwrite
them with the properties passed by the users.


> Add more tests for Kafka Connectors
> -----------------------------------
>
>                 Key: FLINK-1753
>                 URL: https://issues.apache.org/jira/browse/FLINK-1753
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>            Assignee: Gábor Hermann
>
> The current {{KafkaITCase}} is only doing a single test.
> We need to refactor that test so that it brings up a Kafka/Zookeeper server and than
performs various tests:
> Tests to include:
> - A topology with non-string types MERGED IN 359b39c3
> - A topology with a custom Kafka Partitioning class MERGED IN 359b39c3
> - A topology testing the regular {{KafkaSource}}. MERGED IN 359b39c3
> - Kafka broker failure.
> - Flink TaskManager failure



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message