flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1811) Allow users to pass custom buffer sizes and timeouts to PersistentKafkaSource
Date Wed, 01 Apr 2015 13:24:52 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390534#comment-14390534
] 

ASF GitHub Bot commented on FLINK-1811:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/558#discussion_r27568089
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/simple/PersistentKafkaSource.java
---
    @@ -211,6 +215,16 @@ public void run(Collector<OUT> collector) throws Exception
{
     		}
     	}
     
    +	public void setConnectTimeoutMs(int connectTimeoutMs) {
    +		Preconditions.checkArgument(connectTimeoutMs > 0, "The timeout must be positive");
    +		this.connectTimeoutMs = connectTimeoutMs;
    +	}
    +
    +	public void setBufferSize(int bufferSize) {
    +		Preconditions.checkArgument(connectTimeoutMs > 0, "The buffer size be positive");
    --- End diff --
    
    typo: missing "must"... I think we should add these checks in the constructor as well.


> Allow users to pass custom buffer sizes and timeouts to PersistentKafkaSource
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-1811
>                 URL: https://issues.apache.org/jira/browse/FLINK-1811
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>            Priority: Minor
>
> Right now, the call to the Kafka's {{SimpleConsumer}} contains hard coded values that
users can not change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message