flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maximilian Michels (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1821) simplify coding
Date Tue, 07 Apr 2015 09:14:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482889#comment-14482889
] 

Maximilian Michels commented on FLINK-1821:
-------------------------------------------

I prefer explicit branching of the condition. With the {{else}} part, the code looks clearer
to me. It's a question of preference and you might decide to do it differently in your code.

> simplify coding 
> ----------------
>
>                 Key: FLINK-1821
>                 URL: https://issues.apache.org/jira/browse/FLINK-1821
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>            Reporter: Liu Jiongzhou
>            Assignee: Liu Jiongzhou
>
> There is no need to maintain an "else" syntax in line 157 of org.apache.flink.util.AbstractID.
> Remove it for coding simplification.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message