flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From szape <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1595] [streaming] Complex integration t...
Date Mon, 04 May 2015 12:10:41 GMT
Github user szape commented on the pull request:

    https://github.com/apache/flink/pull/520#issuecomment-98689457
  
    Of course, I'm on it.
    I agree, separate tests would be much better. I'll try
    MiltipleProgramsTestBase for that purpose.
    
    Peter
    
    2015-05-04 10:21 GMT+02:00 Márton Balassi <notifications@github.com>:
    
    > Hey,
    >
    > Sorry for not attending to this for a long time. It needed a rebase for
    > the API of the chaining. Now that I have updated that the test throws the
    > following NPE:
    >
    > Caused by: java.lang.NullPointerException
    > at
    > org.apache.flink.streaming.api.complex.ComplexIntegrationTest$MyTimestamp.getTimestamp(ComplexIntegrationTest.java:659)
    > at
    > org.apache.flink.streaming.api.complex.ComplexIntegrationTest$MyTimestamp.getTimestamp(ComplexIntegrationTest.java:654)
    > at
    > org.apache.flink.streaming.api.windowing.helper.TimestampWrapper.getTimestamp(TimestampWrapper.java:34)
    > at
    > org.apache.flink.streaming.api.windowing.windowbuffer.SlidingTimePreReducer.afterEmit(SlidingTimePreReducer.java:71)
    > at
    > org.apache.flink.streaming.api.windowing.windowbuffer.SlidingPreReducer.emitWindow(SlidingPreReducer.java:59)
    > ... 7 more
    >
    > It would be nice if we could separate the individual tests, so it is
    > easier to track an exception like that. Maybe a solution similar to
    > MiltipleProgramsTestBase for streaming would do the trick.
    >
    > @szape <https://github.com/szape>, could you please do an update with
    > these, then I'd merge it asap so that it does not get outdated again.
    > Thanks.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/flink/pull/520#issuecomment-98628873>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message