flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [WIP] - [FLINK-1807/1889] - Optimization frame...
Date Mon, 04 May 2015 13:19:51 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/613#issuecomment-98702926
  
    The refactoring looks really good @thvasilo. I had only two comments:
    
    1. Why do we limit the optimization framework to linear models?
    2. Why do we calculate the regularization gradient for each data point in the gradient
calculation phase and not in the weight update step?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message