flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1933] Add distance measure interface an...
Date Thu, 07 May 2015 09:05:11 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/629#issuecomment-99785066
  
    @chiwanpark, looks really good. I had only one comment concerning the cosine distance.
    
    Furthermore, I was wondering whether we should rename `DistanceMeasure` into `Distance`
or `DistanceMetric` because in all the ScalaDocs we say "The XYZ distance metric ....". What
do you think?
    
    After clarifying these questions, I think it is good to be merged :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message