flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1907] Scala shell
Date Thu, 14 May 2015 15:55:13 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/672#issuecomment-102082153
  
    The change looks good, I had some easy to resolve comments.
    Sadly, it seems that most of the changes are caused by the semantics change of `print()`
... the scalashell code doesn't seem to be so much.
    
    We certainly need to update the documentation as well. A lot of code examples are doing
print() and execute() together.
    The docs should explain what print() is doing.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message