flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbalassi <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1977] Rework Stream Operators to always...
Date Fri, 15 May 2015 08:38:58 GMT
Github user mbalassi commented on the pull request:

    https://github.com/apache/flink/pull/659#issuecomment-102319519
  
    A couple of comments:
    
      * As I see you do not introduce the PollingSourceFunction, this leads to  the following
point :)
       * I would have the Flume package completely commented out. Then remove it and add a
JIRA to rewrite it from scratch. This is blocked by defining the PollingSourceFunction interface.
       * The naming of the two input operators is a bit tricky currently: the base interface
is called two input stream operator and the operatorars themselves still have the co prefix.
I can be fine by both but it would be nice if it was the same.
       * I do not see the updates for the FileMonitoring function here. Do you have them hidden
somewhere? :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message