flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink pull request: [gelly][Refactoring] Removed example string
Date Fri, 15 May 2015 11:22:54 GMT
Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/625#issuecomment-102373199
  
    Hi @andralungu,
    
    regarding `EdgeWithLongIdNullValueParser`: good catch, let's remove it then.
    
    As for the renaming, I would like the examples naming to be consistent. Right now, we
have some named `xyzExample` like `GSAConnectedComponentsExample` and others without "Example"
in the end, like `GSAPageRank`. I personally don't like "Example" in the end, because it makes
class names unnecessarily long (we already know they're examples since they're in the respective
package).
    For the ones that don't use a library method, this is no problem. For the ones that use
a library method and we have a collision. I guess we have two choices: (a) keep the word "Example"
for the ones using a library method or (b) renaming the library methods to something like
`xzyAlgorithm`.
    
    Any other ideas?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message