flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
Date Fri, 15 May 2015 03:42:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544864#comment-14544864
] 

ASF GitHub Bot commented on FLINK-1711:
---------------------------------------

GitHub user lokeshrajaram reopened a pull request:

    https://github.com/apache/flink/pull/673

    [FLINK-1711] - Converted all usages of Commons Validate to Guava Checks(for Java classes),
Scala predef require(for Scala classes)

    [FLINK-1711] - Converted all usages of Commons Validate to Guava Checks(for Java classes),
Scala predef require(for Scala classes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lokeshrajaram/flink all_guava

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #673
    
----
commit 04e1695d3b8414616216264a5b0972d762664ec7
Author: lrajaram <lokesh_rajaram@intuit.com>
Date:   2015-05-10T01:57:36Z

    converted all usages of Commons Validate to Guava Checks

commit 4f68d03d50d0fab47f5067906ec805f4a8b93cfa
Author: lrajaram <lokesh_rajaram@intuit.com>
Date:   2015-05-14T02:29:03Z

    converted all usages of commons validate to guava checks(for Java classes), scala predef
require(for scala classes)

commit 1ecf70952a75728a2e2b9ae70e8f2c66ca9d337a
Author: lrajaram <lokesh_rajaram@intuit.com>
Date:   2015-05-14T14:43:03Z

    added guava dependency for flink-spargel module

----


> Replace all usages off commons.Validate with guava.check
> --------------------------------------------------------
>
>                 Key: FLINK-1711
>                 URL: https://issues.apache.org/jira/browse/FLINK-1711
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 0.9
>            Reporter: Stephan Ewen
>            Assignee: Lokesh Rajaram
>            Priority: Minor
>              Labels: easyfix, starter
>             Fix For: 0.9
>
>
> Per discussion on the mailing list, we decided to increase homogeneity. One part is to
consistently use the Guava methods {{checkNotNull}} and {{checkArgument}}, rather than Apache
Commons Lang3 {{Validate}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message