flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1792) Improve TM Monitoring: CPU utilization, hide graphs by default and show summary only
Date Mon, 04 May 2015 08:54:06 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526430#comment-14526430

ASF GitHub Bot commented on FLINK-1792:

Github user rmetzger commented on the pull request:

    I tried our your changes and looked at the change.
    - The pull request includes commits which are probably not part of the change. Maybe some
merging/rebasing went wrong. Can you try to clean up the branch? Maybe a simple rebase on
the current master is sufficient, or you might need to manually cherry-pick your changes on
the current master.
    - The "Avg" value of the "Memory Statistics" are not aligned. Probably because the positioning
is done using spaces. I think it would be better to use a table there.
    - The position of the "Show Detailed Graph" and the "Hide Detailed Graph" button is not
consistent. On is on the bottom of the table cell, the other on the top.

> Improve TM Monitoring: CPU utilization, hide graphs by default and show summary only
> ------------------------------------------------------------------------------------
>                 Key: FLINK-1792
>                 URL: https://issues.apache.org/jira/browse/FLINK-1792
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Webfrontend
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>            Assignee: Sachin Bhat
> As per https://github.com/apache/flink/pull/421 from FLINK-1501, there are some enhancements
to the current monitoring required
> - Get the CPU utilization in % from each TaskManager process
> - Remove the metrics graph from the overview and only show the current stats as numbers
(cpu load, heap utilization) and add a button to enable the detailed graph.

This message was sent by Atlassian JIRA

View raw message