flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1874) Break up streaming connectors into submodules
Date Wed, 27 May 2015 13:42:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560975#comment-14560975
] 

ASF GitHub Bot commented on FLINK-1874:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/719#issuecomment-105914769
  
    I'm not so sure about the module names.
    The parent is called.
    `flink-streaming-connectors-parent`
    The modules itself are called:
    ```diff
    +	<modules>
    +		<module>flink-flume-connector</module>
    +		<module>flink-kafka-connector</module>
    +		<module>flink-rabbitmq-connector</module>
    +		<module>flink-twitter-connector</module>
    +	</modules>
    ```
    
    It would be more logical to call them:
    `flink-streaming-connectors-flume`, `flink-streaming-connectors-kafka`.
    
    Including `streaming` into the name would make it clear that these connectors are not
usable with the batch system.
    For `kafka` we might want to provide a batch source at some point (we do already through
the kafka hadoop input format).
    
    I think I'm slightly in favor of calling them `flink-streaming-connectors-flume`.
    Any other opinions?


> Break up streaming connectors into submodules
> ---------------------------------------------
>
>                 Key: FLINK-1874
>                 URL: https://issues.apache.org/jira/browse/FLINK-1874
>             Project: Flink
>          Issue Type: Task
>          Components: Build System, Streaming
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>            Assignee: Márton Balassi
>              Labels: starter
>
> As per: http://apache-flink-incubator-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Break-up-streaming-connectors-into-subprojects-td5001.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message