flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2297] [ml] Add threshold setting for SV...
Date Wed, 01 Jul 2015 08:43:35 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/874#discussion_r33658909
  
    --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/SVM.scala
---
    @@ -242,8 +275,21 @@ object SVM{
             }
           }
     
    -      override def predict(value: T, model: DenseVector): Double = {
    -        value.asBreeze dot model.asBreeze
    +      override def predict(value: T, model: DenseVector, predictParameters: ParameterMap):
    +        Double = {
    +        val thresholdOption = predictParameters.get(Threshold)
    +
    +        val rawValue = value.asBreeze dot model.asBreeze
    +        // If the Threshold option has been reset, we will get back a Some(None) thresholdOption
    +        // causing the exception when we try to get the value. In that case we just return
the
    +        // raw value
    +        try {
    +          val thresOptionValue = thresholdOption.get
    +          if (rawValue > thresOptionValue) 1.0 else -1.0
    +        }
    +        catch {
    +          case e: java.lang.ClassCastException => rawValue
    +        }
    --- End diff --
    
    This is indeed hacky. I would vote for reworking it. The problem is that you're assigning
an `Option` to the parameter map where a `double` is required. I'm actually surprised that
this compiles.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message