flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2297] [ml] Add threshold setting for SV...
Date Wed, 01 Jul 2015 08:46:03 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/874#discussion_r33659114
  
    --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/common/ParameterMap.scala
---
    @@ -112,7 +112,7 @@ object ParameterMap {
      *
      * @tparam T Type of parameter value associated to this parameter key
      */
    -trait Parameter[T] {
    +trait Parameter[+T] {
    --- End diff --
    
    For what purposes do we need a covariant parameter type?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message