flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2138] Added custom partitioning to Data...
Date Wed, 01 Jul 2015 08:47:38 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/872#issuecomment-117544452
  
    -1
    Documentation is missing.
    
    http://flink.apache.org/coding-guidelines.html:
    > Documentation Updates. Many changes in the system will also affect the documentation
(both JavaDocs and the user documentation in the docs/ directory.). Pull requests and patches
are required to update the documentation accordingly, otherwise the change can not be accepted
to the source code.
    
    Could you also add an IT case that ensures that the data is actually partitioned properly?
The test you've added is only ensuring that the partitioning properties are set correctly
in the `DataStream`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message