flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thvasilo <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2297] [ml] Add threshold setting for SV...
Date Wed, 01 Jul 2015 09:32:10 GMT
Github user thvasilo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/874#discussion_r33662458
  
    --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/pipeline/Predictor.scala
---
    @@ -121,7 +121,7 @@ object Predictor {
     
             input.mapWithBcVariable(model){
               (element, model) => {
    -            (element, predictOperation.predict(element, model))
    +            (element, predictOperation.predict(element, model, resultingParameters))
    --- End diff --
    
    In this case the output of `predict` depends on the parameter settings. With access only
to `value` and `model` we can't know what to output otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message