flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aalexandrov <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2200] Add Flink with Scala 2.11 in Mave...
Date Fri, 03 Jul 2015 11:44:19 GMT
Github user aalexandrov commented on the pull request:

    https://github.com/apache/flink/pull/885#issuecomment-118326627
  
    I think that a cleaner solution would be to 
    
    1. Add a `scala.suffix` to the Scala profiles. This should be set as the empty string
for 2.10 and as `_${scala.binary.version}` for 2.11.
    
    2. Append the suffix to the required `artifactId` elements. For example, instead of 
    
    ```
    <artifactId>${flink.clients.artifactId}</artifactId>
    ``` 
    
    you would write 
    
    ```
    <artifactId>flink-clients${scala.suffix}</artifactId>
    ```
    
    IMHO this makes everything a bit easier to read and then a straight-forward to migrate
to the "best practice" way of having a suffix for all profiles in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message