flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2157] [ml] [WIP] Create evaluation fram...
Date Wed, 08 Jul 2015 12:06:55 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala
    @@ -25,11 +25,15 @@ import org.apache.flink.api.scala._
     import org.apache.flink.api.common.operators.Order
     import org.apache.flink.core.memory.{DataOutputView, DataInputView}
     import org.apache.flink.ml.common._
    -import org.apache.flink.ml.pipeline.{FitOperation, PredictDataSetOperation, Predictor}
    +import org.apache.flink.ml.evaluation.RegressionScores
    +import org.apache.flink.ml.math.{DenseVector, BLAS}
    +import org.apache.flink.ml.pipeline._
     import org.apache.flink.types.Value
     import org.apache.flink.util.Collector
    -import org.apache.flink.api.common.functions.{Partitioner => FlinkPartitioner, GroupReduceFunction,
    +import org.apache.flink.api.common.functions.{Partitioner => FlinkPartitioner,
    +  GroupReduceFunction, CoGroupFunction}
    +// TODO: Use only one BLAS interface
    --- End diff --
    You're right. Let's open a separate PR for this.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message