flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2371] improve AccumulatorLiveITCase
Date Tue, 21 Jul 2015 08:38:35 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/925#discussion_r35080434
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java
---
    @@ -109,125 +123,157 @@ public void testProgram() throws Exception {
     			ExecutionEnvironment env = new PlanExtractor();
     			DataSet<String> input = env.fromCollection(inputData);
     			input
    -					.flatMap(new Tokenizer())
     					.flatMap(new WaitingUDF())
     					.output(new WaitingOutputFormat());
     			env.execute();
     
    -			/** Extract job graph **/
    +			// Extract job graph and set job id for the task to notify of accumulator changes.
     			JobGraph jobGraph = getOptimizedPlan(((PlanExtractor) env).plan);
    +			jobID = jobGraph.getJobID();
    +
    +			// register for accumulator changes
    +			jobManager.tell(new TestingJobManagerMessages.NotifyWhenAccumulatorChange(jobID),
getRef());
    +			expectMsgEquals(true);
    --- End diff --
    
    Thanks, I've added a timeout to each call of `expectMsgEquals` and `receive`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message