flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2371] improve AccumulatorLiveITCase
Date Tue, 21 Jul 2015 10:12:03 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/925#discussion_r35087953
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
---
    @@ -51,10 +51,13 @@ import scala.concurrent.{ExecutionContext, Future, Await}
     abstract class FlinkMiniCluster(
         val userConfiguration: Configuration,
         val singleActorSystem: Boolean,
    +    val synchronousDispatcher: Boolean,
         val streamingMode: StreamingMode) {
     
    -  def this(userConfiguration: Configuration, singleActorSystem: Boolean) 
    -         = this(userConfiguration, singleActorSystem, StreamingMode.BATCH_ONLY)
    +  def this(userConfiguration: Configuration,
    +           singleActorSystem: Boolean,
    +           synchronousDispatcher: Boolean)
    +       = this(userConfiguration, singleActorSystem, synchronousDispatcher, StreamingMode.BATCH_ONLY)
    --- End diff --
    
    Good catch. I noticed that as well and already changed that before I saw your answer.
Now only the `TestingCluster` is affected by the changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message