flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2138) PartitionCustom for streaming
Date Wed, 01 Jul 2015 08:48:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609758#comment-14609758
] 

ASF GitHub Bot commented on FLINK-2138:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/872#issuecomment-117544452
  
    -1
    Documentation is missing.
    
    http://flink.apache.org/coding-guidelines.html:
    > Documentation Updates. Many changes in the system will also affect the documentation
(both JavaDocs and the user documentation in the docs/ directory.). Pull requests and patches
are required to update the documentation accordingly, otherwise the change can not be accepted
to the source code.
    
    Could you also add an IT case that ensures that the data is actually partitioned properly?
The test you've added is only ensuring that the partitioning properties are set correctly
in the `DataStream`.


> PartitionCustom for streaming
> -----------------------------
>
>                 Key: FLINK-2138
>                 URL: https://issues.apache.org/jira/browse/FLINK-2138
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming
>    Affects Versions: 0.9
>            Reporter: Márton Balassi
>            Assignee: Gábor Hermann
>            Priority: Minor
>
> The batch API has support for custom partitioning, this should be added for streaming
with a similar signature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message