flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2248) Allow disabling of sdtout logging output
Date Fri, 31 Jul 2015 11:51:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649117#comment-14649117
] 

ASF GitHub Bot commented on FLINK-2248:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/957#discussion_r35966826
  
    --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendLoggingTest.java
---
    @@ -0,0 +1,114 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.client;
    +
    +import org.apache.flink.configuration.ConfigConstants;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.runtime.StreamingMode;
    +import org.apache.flink.runtime.minicluster.LocalFlinkMiniCluster;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +import java.io.ByteArrayOutputStream;
    +import java.io.OutputStream;
    +import java.io.PrintStream;
    +
    +import static org.apache.flink.client.CliFrontendTestUtils.getTestJarPath;
    +import static org.apache.flink.client.CliFrontendTestUtils.getConfigDir;
    +import static org.junit.Assert.fail;
    +
    +public class CliFrontendLoggingTest {
    +
    +	private static LocalFlinkMiniCluster cluster;
    +	private static Configuration config;
    +	private static String hostPort;
    +	private ByteArrayOutputStream stream = new ByteArrayOutputStream();
    +	private CliFrontend cli;
    +	private OutputStream output;
    +
    +	@Before
    +	public void setUp() throws Exception {
    +		stream.reset();
    +		output = System.out;
    +		System.setOut(new PrintStream(stream));
    +
    +		config = new Configuration();
    +		config.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, "localhost");
    +		config.setInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, 2);
    +		config.setInteger(ConfigConstants.LOCAL_INSTANCE_MANAGER_NUMBER_TASK_MANAGER, 1);
    +		config.setBoolean(ConfigConstants.LOCAL_INSTANCE_MANAGER_START_WEBSERVER, false);
    +		hostPort = config.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, null) + ":"
+
    +				config.getInteger(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY, ConfigConstants.DEFAULT_JOB_MANAGER_IPC_PORT);
    +
    +		try {
    +			cluster = new LocalFlinkMiniCluster(config, false, StreamingMode.BATCH_ONLY);
    +		}
    +		catch (Exception e) {
    +			e.printStackTrace();
    +			fail("Setup of test actor system failed.");
    +		}
    +
    +		cli = new CliFrontend(getConfigDir());
    +	}
    +
    +	@After
    +	public void shutDownActorSystem() {
    +		System.setOut(new PrintStream(output));
    --- End diff --
    
    I think it should be `System.setOut(output)` here.


> Allow disabling of sdtout logging output
> ----------------------------------------
>
>                 Key: FLINK-2248
>                 URL: https://issues.apache.org/jira/browse/FLINK-2248
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Theodore Vasiloudis
>            Priority: Minor
>              Labels: starter
>
> Currently when a job is submitted through the CLI we get in stdout all the log output
about each stage in the job.
> It would useful to have an easy way to disable this output when submitting the job, as
most of the time we are only interested in the log output if something goes wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message