flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chiwanpark <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2200] Add Flink with Scala 2.11 in Mave...
Date Fri, 03 Jul 2015 10:23:10 GMT
GitHub user chiwanpark opened a pull request:

    https://github.com/apache/flink/pull/885

    [FLINK-2200] Add Flink with Scala 2.11 in Maven Repository

    Hi, This PR contains following changes:
    
    * Add a suffix `_2.11` to all maven modules by profile setting. (`-Pscala-2.11`)
    * Add documentation about using Flink with Scala 2.11.
    
    I defined rules to add the suffix `_2.11` to maven modules. (From suggestion and discussion
in mailing list, thanks @rmetzger)
    
    1. All modules with Scala 2.10 don't have any suffix. (`flink-java`, `flink-core`, `flink-scala`,
..., etc.)
    2. All modules except packaging as pom with Scala 2.11 have the suffix `_2.11`. (`flink-java_2.11`,
`flink-core_2.11`, `flink-scala_2.11`, ..., etc.)
      * `flink-parent`, `flink-quickstart`, `flink-examples`, ..., and etc. don't have any
suffix although they are built with Scala 2.11 because this modules are for only structuring
project.
    3. Currently, `flink-scala-shell` don't have any suffix. But in later, we have to add
suffix to `flink-scala-shell`.
    
    I think that providing quickstart with Scala version variation such as `flink-quickstart-java`,
`flink-quickstart-java_2.11` is good. But I cannot find the method to change architype result
file (`pom.xml` in `src/main/resources/archetype-resources`) by maven profile. So I add explanation
of default scala version in quickstart to documentation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chiwanpark/flink FLINK-2200

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #885
    
----
commit e15ad6749c24a7bc6e2d37370c926981066a52e1
Author: Chiwan Park <chiwanpark@apache.org>
Date:   2015-07-02T17:28:51Z

    [FLINK-2200] [build system] Add scala version suffix to artifact id for Scala 2.11

commit 3bfa184af168d538cbafb527b6238ff945997d95
Author: Chiwan Park <chiwanpark@apache.org>
Date:   2015-07-03T09:16:16Z

    [FLINK-2200] [docs] Add documentation for Flink with Scala 2.11

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message