flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2613] Print usage information for Scala...
Date Thu, 01 Oct 2015 09:15:22 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1106#discussion_r40893325
  
    --- Diff: flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
    @@ -225,6 +220,51 @@ class ScalaShellITSuite extends FunSuite with Matchers with BeforeAndAfterAll
{
         out.toString + stdout
       }
     
    +  /**
    +   * tests flink shell startup with remote cluster (starts cluster internally)
    +   */
    +  test("start flink scala shell with remote cluster") {
    +
    +    val input: String = "val els = env.fromElements(\"a\",\"b\");\n" +
    +      "els.print\nError\n:q\n"
    +
    +    val in: BufferedReader = new BufferedReader(
    +      new StringReader(
    +        input + "\n"))
    +    val out: StringWriter = new StringWriter
    +
    +    val baos: ByteArrayOutputStream = new ByteArrayOutputStream
    +    val oldOut: PrintStream = System.out
    +    System.setOut(new PrintStream(baos))
    +    val c = cluster.getOrElse(null)
    --- End diff --
    
    `null` values are not very scalaesque. Especially since you already have a `Option[ForkableFlinkMiniCluster]`.
Why not simply applying a `map` operation on it or extracting it via pattern matching?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message