flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsaputra <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2741] - Use single log statement in Tes...
Date Sun, 04 Oct 2015 03:48:18 GMT
Github user hsaputra commented on the pull request:

    https://github.com/apache/flink/pull/1221#issuecomment-145315514
  
    Unfortunately looks like this patch does not take advantage of slf4j parameterized logging
[1].
    
    Either do like:
    
    log.info("=================================" + "\nTest " + description + " is running."
+ "\n--------------------------------------------------------------------------------");
    or:
    
    log.info("===============================" + "\nTest {} is running." + "\n--------------------------------------------------------------------------------",
description);
    
    
    [1] http://www.slf4j.org/faq.html#logging_performance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message