flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chiwanpark <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2815] [REFACTOR] Remove Pact from class...
Date Sun, 04 Oct 2015 20:06:31 GMT
Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1218#discussion_r41101714
  
    --- Diff: flink-staging/flink-tez/src/main/java/org/apache/flink/tez/runtime/TezTask.java
---
    @@ -402,7 +402,7 @@ private void initInputLocalStrategy(int inputNum) throws Exception
{
     						localStub = initStub(userCodeFunctionType);
     					} catch (Exception e) {
     						throw new RuntimeException("Initializing the user code and the configuration failed"
+
    -								e.getMessage() == null ? "." : ": " + e.getMessage(), e);
    +								(e.getMessage() == null ? "." : ": ") + e.getMessage(), e);
    --- End diff --
    
    It seems wrong parenthesis. If `e.getMessage()` is `null`, there is concatenation of `"."`
and `null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message