flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Date Mon, 05 Oct 2015 07:35:14 GMT
Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/1219#issuecomment-145450299
  
    Thanks for this! Looks good. I would make the naming consistent though. You mix `jmConfig`
and `config`. I am for `jobManagerConfig` to make it really clear what it is. I will try this
out and merge if it works as expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message