flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: Stream API Refactoring
Date Mon, 05 Oct 2015 09:34:30 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1215#discussion_r41125469
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/IterativeDataStream.java
---
    @@ -81,56 +81,56 @@ protected IterativeDataStream(DataStream<T> dataStream, long
maxWaitTime) {
     	/**
     	 * Changes the feedback type of the iteration and allows the user to apply
     	 * co-transformations on the input and feedback stream, as in a
    -	 * {@link ConnectedDataStream}.
    +	 * {@link ConnectedStreams}.
     	 *
     	 * <p>
     	 * For type safety the user needs to define the feedback type
     	 * 
     	 * @param feedbackTypeString
     	 *            String describing the type information of the feedback stream.
    -	 * @return A {@link ConnectedIterativeDataStream}.
    +	 * @return A {@link ConnectedIterativeDataStreams}.
     	 */
    -	public <F> ConnectedIterativeDataStream<T, F> withFeedbackType(String feedbackTypeString)
{
    +	public <F> ConnectedIterativeDataStreams<T, F> withFeedbackType(String feedbackTypeString)
{
     		return withFeedbackType(TypeInfoParser.<F> parse(feedbackTypeString));
     	}
     
     	/**
     	 * Changes the feedback type of the iteration and allows the user to apply
     	 * co-transformations on the input and feedback stream, as in a
    -	 * {@link ConnectedDataStream}.
    +	 * {@link ConnectedStreams}.
     	 *
     	 * <p>
     	 * For type safety the user needs to define the feedback type
     	 * 
     	 * @param feedbackTypeClass
     	 *            Class of the elements in the feedback stream.
    -	 * @return A {@link ConnectedIterativeDataStream}.
    +	 * @return A {@link ConnectedIterativeDataStreams}.
     	 */
    -	public <F> ConnectedIterativeDataStream<T, F> withFeedbackType(Class<F>
feedbackTypeClass) {
    +	public <F> ConnectedIterativeDataStreams<T, F> withFeedbackType(Class<F>
feedbackTypeClass) {
     		return withFeedbackType(TypeExtractor.getForClass(feedbackTypeClass));
    --- End diff --
    
    You're right, I'll also rename those.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message