flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...
Date Mon, 05 Oct 2015 10:19:49 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1222#issuecomment-145488471
  
    I gave some comments on the commit.
    
    Looks mainly good, I am only confused why you changed all request URLs to relative from
absolute. This may have other implications. If it is just to get rid of a "slash" in when
creating the file path, you should probably rather prune repeated slashes instead...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message